Stupid Person Error Checking

**David** · March 1st, 2006, 8:02 AM

Atleast, that's what I began calling it when it popped in my head the other day:

Quote:

if ($_POST['cl_pass'] = preg_match("/password/i",$_POST['cl_pass'])){
$error = "ARG!<br/>You can NOT make your password \"Password\"!";
}

Thought I would share. Thoughts? Anything to add to make it more efficient. All it does is check to make sure they aren't doing any variation of Password as their password.

H · March 1st, 2006, 11:37 AM

Code:

<?php
if (strpos(strtolower($_POST['cl_pass']),'password')) {
$error = "ARG!<br/>You can NOT make your password \"Password\"!";
}
?>

**David** · March 1st, 2006, 6:50 PM

Ok. Now, why is that more efficient? An explination would help, as per usual with me. It just seems like running two functions verses one would not be better.

**mr_fern** · March 1st, 2006, 8:04 PM

Regular expressions are more "expensive" on the CPU than regular string matching.

That's why they suggest using string matching instead of pattern matching for simple searches (i.e. a particular word is in a word/sentence)

**David** · March 1st, 2006, 8:09 PM

Ok, and using the above method would work as a case-insensitive search? That's why I went with regex in the first place, was because I couldn't find another way to find case variations of the word.

**David** · March 1st, 2006, 8:15 PM

Ok, I think I understand now. strtolower will lowercase it all if the word is Password. But will it do it if it's PasSWorD? Of course, I guess I could just try it and find out.

edit: ok, I tried it and it didn't work at all any more. Every variation of the word password that I tried was submitted successfully.

H · March 1st, 2006, 8:43 PM

Ok, I know what it's not working. If you start password as the first character, it sets the value to 0, or false.

PHP Code:


			
<?php

if (strpos('_'.strtolower($_POST['cl_pass']),'password')) {

$error = "ARG!<br/>You can NOT make your password \"Password\"!";

}

?>

**David** · March 1st, 2006, 8:45 PM

I'm not following. I see that you added the '_' to it, but I'm not understanding what that just did.

H · March 1st, 2006, 8:46 PM

Ack.. What was I thinking?

PHP Code:


			
<?php

if (strstr(strtolower($_POST['cl_pass']),'password')) {

$error = "ARG!<br/>You can NOT make your password \"Password\"!";

}

?>

Using strstr() doesn't check for the position, while strpos() does. Doh!

March 1st, 2006, 11:37 AM	#2 (permalink)
H after g, before i Resident. Joined in Jul 2004 Lives in N,BC,CA 8,092 posts Gave thanks: 48 Thanked 131 times	Code: <?php if (strpos(strtolower($_POST['cl_pass']),'password')) { $error = "ARG!<br/>You can NOT make your password \"Password\"!"; } ?>

March 1st, 2006, 8:04 PM	#4 (permalink)
mr_fern All Ur Base R Belong 2 Us Excelling Contributor Joined in Feb 2005 Lives in Vegas & New York 824 posts Gave thanks: 2 Thanked 6 times	Regular expressions are more "expensive" on the CPU than regular string matching. That's why they suggest using string matching instead of pattern matching for simple searches (i.e. a particular word is in a word/sentence) __________________ Nobody doing nothing

March 1st, 2006, 8:43 PM	#7 (permalink)
H after g, before i Resident. Joined in Jul 2004 Lives in N,BC,CA 8,092 posts Gave thanks: 48 Thanked 131 times	Ok, I know what it's not working. If you start password as the first character, it sets the value to 0, or false. PHP Code: `<?php if (strpos('_'.strtolower($_POST['cl_pass']),'password')) { $error = "ARG!<br/>You can NOT make your password \"Password\"!"; } ?>`

March 1st, 2006, 8:46 PM	#9 (permalink)
H after g, before i Resident. Joined in Jul 2004 Lives in N,BC,CA 8,092 posts Gave thanks: 48 Thanked 131 times	Ack.. What was I thinking? PHP Code: `<?php if (strstr(strtolower($_POST['cl_pass']),'password')) { $error = "ARG!<br/>You can NOT make your password \"Password\"!"; } ?>` Using strstr() doesn't check for the position, while strpos() does. Doh!

Thread Tools	Search this Thread
Show Printable Version Email this Page	Search this Thread: Advanced Search
Rate This Thread
Rate This Thread:

Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)